From: Peng Li <lipeng321@huawei.com>
Date: Fri, 18 Jun 2021 02:32:19 +0000 (+0800)
Subject: net: hostess_sv11: move out assignment in if condition
X-Git-Tag: v5.14-rc1~119^2~124^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fe9be8daef8a7e6bd539fa57a9e14c6b4f8261f7;p=thirdparty%2Flinux.git

net: hostess_sv11: move out assignment in if condition

Should not use assignment in if condition.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/wan/hostess_sv11.c b/drivers/net/wan/hostess_sv11.c
index a18c09dc335cb..8dce8b190420d 100644
--- a/drivers/net/wan/hostess_sv11.c
+++ b/drivers/net/wan/hostess_sv11.c
@@ -340,7 +340,8 @@ static struct z8530_dev *sv11_unit;
 
 int init_module(void)
 {
-	if ((sv11_unit = sv11_init(io, irq)) == NULL)
+	sv11_unit = sv11_init(io, irq);
+	if (!sv11_unit)
 		return -ENODEV;
 	return 0;
 }