From: René Scharfe <l.s.r@web.de>
Date: Sun, 22 Sep 2024 13:40:42 +0000 (+0200)
Subject: commit-graph: remove unnecessary UNLEAK
X-Git-Tag: v2.47.0-rc1~9^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff0eb72fb62919b744dba2c41f09e01d494971df;p=thirdparty%2Fgit.git

commit-graph: remove unnecessary UNLEAK

When f4dbdfc4d5 (commit-graph: clean up leaked memory during write,
2018-10-03) added the UNLEAK, it was right before a call to die_errno().
e103f7276f (commit-graph: return with errors during write, 2019-06-12)
made it unnecessary, as it was then followed by a free() call for the
allocated string.

The code moved to write_commit_graph_file() in the meantime and the
string pointer is now part of a struct, but the function's only caller
still cleans up the allocation.  Drop the superfluous UNLEAK.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/commit-graph.c b/commit-graph.c
index aa6e08eb39..5bd89c0acd 100644
--- a/commit-graph.c
+++ b/commit-graph.c
@@ -2055,7 +2055,6 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
 	}
 
 	if (safe_create_leading_directories(ctx->graph_name)) {
-		UNLEAK(ctx->graph_name);
 		error(_("unable to create leading directories of %s"),
 			ctx->graph_name);
 		return -1;