From: DJ Delorie <dj@redhat.com>
Date: Wed, 30 Oct 2019 22:03:14 +0000 (-0400)
Subject: Base max_fast on alignment, not width, of bins (Bug 24903)
X-Git-Tag: glibc-2.31~309
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff12e0fb91b9072800f031cb21fb2651ee7b6251;p=thirdparty%2Fglibc.git

Base max_fast on alignment, not width, of bins (Bug 24903)

set_max_fast sets the "impossibly small" value based on,
eventually, MALLOC_ALIGNMENT.  The comparisons for the smallest
chunk used is, eventually, MIN_CHUNK_SIZE.  Note that i386
is the only platform where these are the same, so a smallest
chunk *would* be put in a no-fastbins fastbin.

This change calculates the "impossibly small" value
based on MIN_CHUNK_SIZE instead, so that we can know it will
always be impossibly small.
---

diff --git a/malloc/malloc.c b/malloc/malloc.c
index 5d3e82a8f6e..70cc35a4733 100644
--- a/malloc/malloc.c
+++ b/malloc/malloc.c
@@ -1621,7 +1621,7 @@ static INTERNAL_SIZE_T global_max_fast;
 
 #define set_max_fast(s) \
   global_max_fast = (((s) == 0)						      \
-                     ? SMALLBIN_WIDTH : ((s + SIZE_SZ) & ~MALLOC_ALIGN_MASK))
+                     ? MIN_CHUNK_SIZE / 2 : ((s + SIZE_SZ) & ~MALLOC_ALIGN_MASK))
 
 static inline INTERNAL_SIZE_T
 get_max_fast (void)