From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 16 Oct 2024 14:41:44 +0000 (+0300)
Subject: net: ethernet: ti: am65-cpsw: Fix uninitialized variable
X-Git-Tag: v6.13-rc1~135^2~297
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff1d3484d6d29dda92421b9a753e4ca54f91aa8a;p=thirdparty%2Fkernel%2Flinux.git

net: ethernet: ti: am65-cpsw: Fix uninitialized variable

The *ndev pointer needs to be set or it leads to an uninitialized variable
bug in the caller.

Fixes: 4a7b2ba94a59 ("net: ethernet: ti: am65-cpsw: Use tstats instead of open coded version")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Message-ID: <b168d5c7-704b-4452-84f9-1c1762b1f4ce@stanley.mountain>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index acaf06b274cac..6201a09fa5f08 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -1341,6 +1341,7 @@ am65_cpsw_nuss_tx_compl_packet_xdp(struct am65_cpsw_common *common,
 
 	port = am65_common_get_port(common, port_id);
 	dev_sw_netstats_tx_add(port->ndev, 1, xdpf->len);
+	*ndev = port->ndev;
 
 	return xdpf;
 }