From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 6 May 2020 14:13:17 +0000 (+0000)
Subject: soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()
X-Git-Tag: v5.8-rc1~138^2~21^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff34e17cf9bce8b6d01c6a1e387720dc3393f45b;p=thirdparty%2Fkernel%2Flinux.git

soc: mediatek: Missing platform_device_unregister() on error in mtk_mmsys_probe()

Add the missing platform_device_unregister() before return
from mtk_mmsys_probe() in the error handling case.

Fixes: 667c769246b0 ("soc / drm: mediatek: Fix mediatek-drm device probing")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20200506141317.119537-1-weiyongjun1@huawei.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---

diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index bb5ccd5b0386c..b0bb08a66b019 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -311,8 +311,10 @@ static int mtk_mmsys_probe(struct platform_device *pdev)
 
 	drm = platform_device_register_data(&pdev->dev, "mediatek-drm",
 					    PLATFORM_DEVID_AUTO, NULL, 0);
-	if (IS_ERR(drm))
+	if (IS_ERR(drm)) {
+		platform_device_unregister(clks);
 		return PTR_ERR(drm);
+	}
 
 	return 0;
 }