From: Will Deacon Date: Mon, 4 Nov 2019 15:58:15 +0000 (+0000) Subject: firmware: qcom: scm: Ensure 'a0' status code is treated as signed X-Git-Tag: v5.5-rc1~77^2^7~2^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff34f3cce278a0982a7b66b1afaed6295141b1fc;p=thirdparty%2Fkernel%2Flinux.git firmware: qcom: scm: Ensure 'a0' status code is treated as signed The 'a0' member of 'struct arm_smccc_res' is declared as 'unsigned long', however the Qualcomm SCM firmware interface driver expects to receive negative error codes via this field, so ensure that it's cast to 'long' before comparing to see if it is less than 0. Cc: Reviewed-by: Bjorn Andersson Signed-off-by: Will Deacon --- diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c index 91d5ad7cf58b7..25e0f60c759ac 100644 --- a/drivers/firmware/qcom_scm-64.c +++ b/drivers/firmware/qcom_scm-64.c @@ -150,7 +150,7 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id, kfree(args_virt); } - if (res->a0 < 0) + if ((long)res->a0 < 0) return qcom_scm_remap_error(res->a0); return 0;