From: Amit Kapila <akapila@postgresql.org>
Date: Wed, 22 Nov 2023 03:09:24 +0000 (+0530)
Subject: Stop the search once the slot for replication origin is found.
X-Git-Tag: REL_17_BETA1~1423
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff68cc6f3bf08546802216e0b9d28ad1d4be7e70;p=thirdparty%2Fpostgresql.git

Stop the search once the slot for replication origin is found.

In replorigin_session_setup(), we were needlessly looping for
max_replication_slots even after finding an existing slot for the origin.
This shouldn't hurt us much except for probably large values of
max_replication_slots.

Author: Antonin Houska
Discussion: http://postgr.es/m/2694.1700471273@antos
---

diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c
index b0255ffd25a..460e3dcc384 100644
--- a/src/backend/replication/logical/origin.c
+++ b/src/backend/replication/logical/origin.c
@@ -1144,6 +1144,7 @@ replorigin_session_setup(RepOriginId node, int acquired_by)
 
 		/* ok, found slot */
 		session_replication_state = curstate;
+		break;
 	}