From: Jacco van den Berg Date: Fri, 24 May 2024 14:15:28 +0000 (+0200) Subject: Fix drawing angle lines on reversed radial scale (#11788) X-Git-Tag: v4.4.4~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ff740789a5ef722e52b6328417ed148a93a2b926;p=thirdparty%2FChart.js.git Fix drawing angle lines on reversed radial scale (#11788) * Fix drawing angle lines on reversed radial scale * add test * Show ticks in test --------- Co-authored-by: Jacco van den Berg --- diff --git a/src/scales/scale.radialLinear.js b/src/scales/scale.radialLinear.js index 1e3f79690..642fa1c14 100644 --- a/src/scales/scale.radialLinear.js +++ b/src/scales/scale.radialLinear.js @@ -606,7 +606,7 @@ export default class RadialLinearScale extends LinearScaleBase { ctx.setLineDash(optsAtIndex.borderDash); ctx.lineDashOffset = optsAtIndex.borderDashOffset; - offset = this.getDistanceFromCenterForValue(opts.ticks.reverse ? this.min : this.max); + offset = this.getDistanceFromCenterForValue(opts.reverse ? this.min : this.max); position = this.getPointPosition(i, offset); ctx.beginPath(); ctx.moveTo(this.xCenter, this.yCenter); diff --git a/test/fixtures/scale.radialLinear/anglelines-reverse-scale.js b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.js new file mode 100644 index 000000000..af35a68bc --- /dev/null +++ b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.js @@ -0,0 +1,35 @@ +module.exports = { + config: { + type: 'radar', + data: { + labels: ['A', 'B', 'C', 'D', 'E'], + datasets: [{ + data: [1, 1, 2, 3, 5] + }] + }, + options: { + responsive: false, + scales: { + r: { + reverse: true, + grid: { + display: true, + }, + angleLines: { + color: 'red', + lineWidth: 5, + }, + pointLabels: { + display: false + }, + ticks: { + display: true, + } + } + } + } + }, + options: { + spriteText: true, + } +}; diff --git a/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png new file mode 100644 index 000000000..f2367b980 Binary files /dev/null and b/test/fixtures/scale.radialLinear/anglelines-reverse-scale.png differ