From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 28 Nov 2013 16:26:56 +0000 (+0100)
Subject: cpu: Document why cannot_instantiate_with_device_add_yet
X-Git-Tag: v2.0.0-rc0~167^2~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ffa957148698eec9cfdaf6e0c1b43cda8828cd61;p=thirdparty%2Fqemu.git

cpu: Document why cannot_instantiate_with_device_add_yet

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/qom/cpu.c b/qom/cpu.c
index 09c15e6b600..9d624795461 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data)
     k->gdb_read_register = cpu_common_gdb_read_register;
     k->gdb_write_register = cpu_common_gdb_write_register;
     dc->realize = cpu_common_realizefn;
-    dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
+    /*
+     * Reason: CPUs still need special care by board code: wiring up
+     * IRQs, adding reset handlers, halting non-first CPUs, ...
+     */
+    dc->cannot_instantiate_with_device_add_yet = true;
 }
 
 static const TypeInfo cpu_type_info = {