From: Ross Burton Date: Thu, 12 Jul 2018 13:44:06 +0000 (+0100) Subject: insane: optimise buildpath search X-Git-Tag: yocto-4.0~12889 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ffb52d383bfe413cf31fef13663fe9937a146c76;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git insane: optimise buildpath search Instead of decoding every file we open as UTF-8 (with many errors as machine code isn't UTF-8), convert the build path to the UTF-8 byte representation and search for that instead. Signed-off-by: Ross Burton --- diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 713b40eac42..469d5c4cd51 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -535,9 +535,9 @@ def package_qa_check_buildpaths(path, name, d, elf, messages): if path.find(name + "/CONTROL/") != -1 or path.find(name + "/DEBIAN/") != -1: return - tmpdir = d.getVar('TMPDIR') + tmpdir = bytes(d.getVar('TMPDIR'), encoding="utf-8") with open(path, 'rb') as f: - file_content = f.read().decode('utf-8', errors='ignore') + file_content = f.read() if tmpdir in file_content: package_qa_add_message(messages, "buildpaths", "File %s in package contained reference to tmpdir" % package_qa_clean_path(path,d))