From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Thu, 25 Oct 2018 15:21:06 +0000 (+0200)
Subject: OSPF: Fix some trace messages
X-Git-Tag: v1.6.5~27
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fff79b1c1e0577f487b4fb67f79a74b054d734b6;p=thirdparty%2Fbird.git

OSPF: Fix some trace messages

Missing argument in MTU change trace message can crash bird when MTU
change happens and trace messages are active.

Thanks to Alexander Velkov for the bugreport.
---

diff --git a/proto/ospf/hello.c b/proto/ospf/hello.c
index e00487dc6..7f14b6361 100644
--- a/proto/ospf/hello.c
+++ b/proto/ospf/hello.c
@@ -283,7 +283,7 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa,
       if (!ipa_equal(faddr, n->ip))
       {
 	OSPF_TRACE(D_EVENTS, "Neighbor %R on %s changed IP address to %I",
-		   n->rid, ifa->ifname, n->ip, faddr);
+		   n->rid, ifa->ifname, faddr);
 	n->ip = faddr;
       }
     }
diff --git a/proto/ospf/iface.c b/proto/ospf/iface.c
index 1795ec220..6e3a48b3a 100644
--- a/proto/ospf/iface.c
+++ b/proto/ospf/iface.c
@@ -1256,7 +1256,8 @@ ospf_iface_change_mtu(struct ospf_proto *p, struct ospf_iface *ifa)
 {
   /* ifa is not vlink */
 
-  OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d", ifa->iface->mtu);
+  OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d",
+	     ifa->ifname, ifa->iface->mtu);
 
   ifa->tx_length = ifa_tx_length(ifa);