From: Simon Horman Date: Tue, 13 Aug 2024 14:32:55 +0000 (+0100) Subject: bnxt_en: Extend maximum length of version string by 1 byte X-Git-Tag: v6.12-rc1~232^2~258^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=ffff7ee843c351ce71d6e0d52f0f20bea35e18c9;p=thirdparty%2Fkernel%2Flinux.git bnxt_en: Extend maximum length of version string by 1 byte This corrects an out-by-one error in the maximum length of the package version string. The size argument of snprintf includes space for the trailing '\0' byte, so there is no need to allow extra space for it by reducing the value of the size argument by 1. Found by inspection. Compile tested only. Signed-off-by: Simon Horman Reviewed-by: Michael Chan Link: https://patch.msgid.link/20240813-bnxt-str-v2-1-872050a157e7@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 61d6afc3cacb7..39eed5831e3ab 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -4161,7 +4161,7 @@ static void bnxt_get_pkgver(struct net_device *dev) if (!bnxt_get_pkginfo(dev, buf, sizeof(buf))) { len = strlen(bp->fw_ver_str); - snprintf(bp->fw_ver_str + len, FW_VER_STR_LEN - len - 1, + snprintf(bp->fw_ver_str + len, FW_VER_STR_LEN - len, "/pkg %s", buf); } }