From: Maria Matejka <mq@ucw.cz>
Date: Wed, 16 Jan 2019 15:39:29 +0000 (+0100)
Subject: Nest: fixed corner cases on deleting from fib
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fheads%2Fmq-ordered;p=thirdparty%2Fbird.git

Nest: fixed corner cases on deleting from fib
---

diff --git a/nest/rt-fib.c b/nest/rt-fib.c
index e13603575..d9afccb2a 100644
--- a/nest/rt-fib.c
+++ b/nest/rt-fib.c
@@ -426,13 +426,13 @@ fib_delete(struct fib *f, void *E)
 	}
 #undef UNDEF
 
+      REDBLACK_DELETE(struct fib_node, rb, f->tree_root, e);
+
       if (f->fib_slab)
 	sl_free(f->fib_slab, E);
       else
 	mb_free(E);
 
-      REDBLACK_DELETE(struct fib_node, rb, f->tree_root, e);
-
       if (f->entries-- < f->entries_min)
 	fib_rehash(f, -HASH_LO_STEP);
       return;
@@ -503,14 +503,20 @@ fit_get(struct fib *f, struct fib_iterator *i)
 void
 fit_put(struct fib_iterator *i, struct fib_node *n)
 {
-  struct fib_iterator *j;
-
   i->node = n;
-  if (j = n->readers)
-    j->prev = i;
-  i->next = j;
-  n->readers = i;
   i->prev = (struct fib_iterator *) n;
+
+  if (!n)
+    {
+      i->next = NULL;
+      return;
+    }
+
+  i->next = n->readers;
+  n->readers = i;
+
+  if (i->next)
+    i->next->prev = i;
 }
 
 void