From: dan <Dan Kennedy>
Date: Wed, 24 Mar 2021 19:57:41 +0000 (+0000)
Subject: Add a comment to snapshotrevert.c warning of the undefined effects reverting to an... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fheads%2Fsnapshot-revert;p=thirdparty%2Fsqlite.git

Add a comment to snapshotrevert.c warning of the undefined effects reverting to an old snapshot may have on newer readers.

FossilOrigin-Name: 00af3bd254a06420167ec0c067206b7c5f5b8bdf191fbdffbbf9793ff50a1452
---

diff --git a/ext/misc/snapshotrevert.c b/ext/misc/snapshotrevert.c
index 8ac8ed422c..34e4a89525 100644
--- a/ext/misc/snapshotrevert.c
+++ b/ext/misc/snapshotrevert.c
@@ -63,6 +63,12 @@ static int snapshotRevertUnlock(sqlite3_file *pFd, int eLock){
 ** not have an open read or write transction on zDb when this function is
 ** called.
 **
+** This function uses normal SQLite locks to ensure that the database is
+** not corrupted by a simultaneous writer or checkpointer. However, the
+** effects of a successful call to this function on readers that are
+** reading from a snapshot newer than the snapshot supplied as the 
+** third argument are undefined.
+**
 ** Return SQLITE_OK if successful, or an SQLite error code otherwise.
 */
 int sqlite3_snapshot_revert(
diff --git a/manifest b/manifest
index e7d114e40d..bbc7b2691c 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Add\sexperimental\sextension\s"snapshotrevert".
-D 2021-03-24T19:54:20.842
+C Add\sa\scomment\sto\ssnapshotrevert.c\swarning\sof\sthe\sundefined\seffects\sreverting\sto\san\sold\ssnapshot\smay\shave\son\snewer\sreaders.
+D 2021-03-24T19:57:41.845
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -324,7 +324,7 @@ F ext/misc/series.c c6bd5d249e5199a1b55aeee4d0e6576ff3a68702fc475dbd64503a329035
 F ext/misc/sha1.c c8f2253c8792ffab9517695ea7d88c079f0395a5505eefef5c8198fe184ed5ac
 F ext/misc/shathree.c e984f31731de4cf302a0386be5fe664580f63d8204c47b9b41cc4b997745f9ec
 F ext/misc/showauth.c 732578f0fe4ce42d577e1c86dc89dd14a006ab52
-F ext/misc/snapshotrevert.c 8cc92c76cab8c9eb50f362427f634f1f20b1d553312a534e1077468d9bd0ebc4
+F ext/misc/snapshotrevert.c 44a3e3fb8835dcb75fd13bfdd02c3a55dfc8e9e3231b4b9d4c9bfe4969ab99e2
 F ext/misc/spellfix.c 94df9bbfa514a563c1484f684a2df3d128a2f7209a84ca3ca100c68a0163e29f
 F ext/misc/sqlar.c 0ace5d3c10fe736dc584bf1159a36b8e2e60fab309d310cd8a0eecd9036621b6
 F ext/misc/stmt.c 35063044a388ead95557e4b84b89c1b93accc2f1c6ddea3f9710e8486a7af94a
@@ -1927,7 +1927,7 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P 7e38c889e7eece521db24c379cb1be7c4c49e2ba4dc04c2a10151793a6bb04df
-R 2122e6e8bbc48457bd5128ae227294a2
+P 2d5ee3bad19ad0d959d3f6fbc592031b0b764c4111bc2aa1b34df6822250ca7e
+R cc60ae9bd3f33006118280fa8caf6d65
 U dan
-Z 4f7dd46938d9c48c2bba28374f57caaf
+Z 238232fa6f255cecadc1f1d6a5554f4b
diff --git a/manifest.uuid b/manifest.uuid
index c8c1520ff0..3477b14b93 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-2d5ee3bad19ad0d959d3f6fbc592031b0b764c4111bc2aa1b34df6822250ca7e
\ No newline at end of file
+00af3bd254a06420167ec0c067206b7c5f5b8bdf191fbdffbbf9793ff50a1452
\ No newline at end of file