From: Otto <otto.moerbeek@open-xchange.com>
Date: Tue, 6 Apr 2021 13:26:35 +0000 (+0200)
Subject: Fix a few warnings as seen on OpenBSD/clang
X-Git-Tag: dnsdist-1.6.0-rc1~24^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10269%2Fhead;p=thirdparty%2Fpdns.git

Fix a few warnings as seen on OpenBSD/clang
---

diff --git a/pdns/test-misc_hh.cc b/pdns/test-misc_hh.cc
index 8cd24a857d..bc10168df2 100644
--- a/pdns/test-misc_hh.cc
+++ b/pdns/test-misc_hh.cc
@@ -266,7 +266,7 @@ BOOST_AUTO_TEST_CASE(test_parseRFC1035CharString)
   in = "hello world";
   expected = "hello";
   amount = parseRFC1035CharString(in, out);
-  BOOST_CHECK_EQUAL(amount, 5);
+  BOOST_CHECK_EQUAL(amount, 5U);
   BOOST_CHECK_EQUAL(out, expected);
 
   // \032 is a space, but it is read because it is escaped
@@ -321,73 +321,73 @@ BOOST_AUTO_TEST_CASE(test_parseSVCBValueList)
 
   // Our tests
   parseSVCBValueList("foobar123", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123");
 
   parseSVCBValueList("h2,h3", out);
-  BOOST_CHECK_EQUAL(out.size(), 2);
+  BOOST_CHECK_EQUAL(out.size(), 2U);
   BOOST_CHECK_EQUAL(out[0], "h2");
   BOOST_CHECK_EQUAL(out[1], "h3");
 
   parseSVCBValueList("h2,h3-19,h3-20,h3-22", out);
-  BOOST_CHECK_EQUAL(out.size(), 4);
+  BOOST_CHECK_EQUAL(out.size(), 4U);
   BOOST_CHECK_EQUAL(out[0], "h2");
   BOOST_CHECK_EQUAL(out[1], "h3-19");
   BOOST_CHECK_EQUAL(out[2], "h3-20");
   BOOST_CHECK_EQUAL(out[3], "h3-22");
 
   parseSVCBValueList("foobar123,bazquux456", out);
-  BOOST_CHECK_EQUAL(out.size(), 2);
+  BOOST_CHECK_EQUAL(out.size(), 2U);
   BOOST_CHECK_EQUAL(out[0], "foobar123");
   BOOST_CHECK_EQUAL(out[1], "bazquux456");
 
   parseSVCBValueList(R"FOO(foobar123\\,bazquux456)FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123,bazquux456");
 
   parseSVCBValueList(R"FOO(foobar123\\\044bazquux456)FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123,bazquux456");
 
   // Again, but quoted
   parseSVCBValueList("\"foobar123\"", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123");
 
   parseSVCBValueList("\"foobar123,bazquux456\"", out);
-  BOOST_CHECK_EQUAL(out.size(), 2);
+  BOOST_CHECK_EQUAL(out.size(), 2U);
   BOOST_CHECK_EQUAL(out[0], "foobar123");
   BOOST_CHECK_EQUAL(out[1], "bazquux456");
 
   parseSVCBValueList(R"FOO("foobar123\\,bazquux456")FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123,bazquux456");
 
   parseSVCBValueList(R"FOO("foobar123\\\044bazquux456")FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123,bazquux456");
 
   // Quoted, with some whitespace
   parseSVCBValueList("\"foobar123 \"", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123 ");
 
   parseSVCBValueList("\"foobar123 blabla bla,baz quux456\"", out);
-  BOOST_CHECK_EQUAL(out.size(), 2);
+  BOOST_CHECK_EQUAL(out.size(), 2U);
   BOOST_CHECK_EQUAL(out[0], "foobar123 blabla bla");
   BOOST_CHECK_EQUAL(out[1], "baz quux456");
 
   parseSVCBValueList("\"foobar123,baz quux456\"", out);
-  BOOST_CHECK_EQUAL(out.size(), 2);
+  BOOST_CHECK_EQUAL(out.size(), 2U);
   BOOST_CHECK_EQUAL(out[0], "foobar123");
   BOOST_CHECK_EQUAL(out[1], "baz quux456");
 
   parseSVCBValueList(R"FOO("foobar123 blabla bla\\,baz quux456")FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123 blabla bla,baz quux456");
 
   parseSVCBValueList(R"FOO("foobar123 blabla bla\\\044baz quux456")FOO", out);
-  BOOST_CHECK_EQUAL(out.size(), 1);
+  BOOST_CHECK_EQUAL(out.size(), 1U);
   BOOST_CHECK_EQUAL(out[0], "foobar123 blabla bla,baz quux456");
 }