From: Sander Steffann <sander@steffann.nl>
Date: Tue, 20 Jul 2021 11:02:41 +0000 (+0200)
Subject:  Document setTag(Array) behaviour
X-Git-Tag: dnsdist-1.7.0-alpha1~75^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10601%2Fhead;p=thirdparty%2Fpdns.git

 Document setTag(Array) behaviour

Explicitly document that setTag and setTagArray do not overwrite existing tag values.
---

diff --git a/pdns/dnsdistdist/docs/reference/dq.rst b/pdns/dnsdistdist/docs/reference/dq.rst
index 546e1d7c9b..76a432a1ef 100644
--- a/pdns/dnsdistdist/docs/reference/dq.rst
+++ b/pdns/dnsdistdist/docs/reference/dq.rst
@@ -222,14 +222,16 @@ This state can be modified from the various hooks.
   .. method:: DNSQuestion:setTag(key, value)
 
     Set a tag into the DNSQuestion object.
-
+    This function will not overwrite an existing tag. If the tag already exists it will keep its original value.
+  
     :param string key: The tag's key
     :param string value: The tag's value
 
   .. method:: DNSQuestion:setTagArray(tags)
 
     Set an array of tags into the DNSQuestion object.
-
+    This function will not overwrite an existing tag. If the tag already exists it will keep its original value.
+  
     :param table tags: A table of tags, using strings as keys and values
 
   .. method:: DNSQuestion:setTrailingData(tail) -> bool