From: Otto <otto.moerbeek@open-xchange.com>
Date: Tue, 3 Aug 2021 07:08:09 +0000 (+0200)
Subject: Check in more places if the config policy has been updated before
X-Git-Tag: rec-4.4.6~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10628%2Fhead;p=thirdparty%2Fpdns.git

Check in more places if the config policy has been updated before
using or modifying it.

(cherry picked from commit 0c98e3de2cf1daae3f7034803668c1ac10fefe49)
---

diff --git a/pdns/rpzloader.cc b/pdns/rpzloader.cc
index 212c926052..7f6a78cdca 100644
--- a/pdns/rpzloader.cc
+++ b/pdns/rpzloader.cc
@@ -458,7 +458,15 @@ void RPZIXFRTracker(const std::vector<ComboAddress>& masters, boost::optional<DN
     try {
       g_log<<Logger::Info<<"Processing "<<deltas.size()<<" delta"<<addS(deltas)<<" for RPZ "<<zoneName<<endl;
 
+      if (luaconfsLocal->generation != configGeneration) {
+        g_log<<Logger::Info<<"A more recent configuration has been found, stopping the existing RPZ update thread for "<<zoneName<<endl;
+        return;
+      }
       oldZone = luaconfsLocal->dfe.getZone(zoneIdx);
+      if (!oldZone || oldZone->getDomain() != zoneName) {
+        g_log<<Logger::Info<<"This policy is no more, stopping the existing RPZ update thread for "<<zoneName << endl;
+        return;
+      }
       /* we need to make a _full copy_ of the zone we are going to work on */
       std::shared_ptr<DNSFilterEngine::Zone> newZone = std::make_shared<DNSFilterEngine::Zone>(*oldZone);
       /* initialize the current serial to the last one */
@@ -529,6 +537,10 @@ void RPZIXFRTracker(const std::vector<ComboAddress>& masters, boost::optional<DN
          but we don't want to touch anything else, especially other zones,
          since they might have been updated by another RPZ IXFR tracker thread.
       */
+      if (luaconfsLocal->generation != configGeneration) {
+        g_log<<Logger::Info<<"A more recent configuration has been found, stopping the existing RPZ update thread for "<<zoneName<<endl;
+        return;
+      }
       g_luaconfs.modify([zoneIdx, &newZone](LuaConfigItems& lci) {
                           lci.dfe.setZone(zoneIdx, newZone);
                         });