From: Remi Gacogne Date: Mon, 13 Sep 2021 14:11:58 +0000 (+0200) Subject: dnsdist: The 'number of TCP workers' revert did not make it to 1.6.1 X-Git-Tag: dnsdist-1.7.0-alpha1~18^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10704%2Fhead;p=thirdparty%2Fpdns.git dnsdist: The 'number of TCP workers' revert did not make it to 1.6.1 --- diff --git a/pdns/dnsdistdist/docs/reference/tuning.rst b/pdns/dnsdistdist/docs/reference/tuning.rst index f899951077..df29593ec9 100644 --- a/pdns/dnsdistdist/docs/reference/tuning.rst +++ b/pdns/dnsdistdist/docs/reference/tuning.rst @@ -13,14 +13,14 @@ Tuning related functions .. versionchanged:: 1.6.0 Before 1.6.0 the default value was 10. - .. versionchanged:: 1.6.1 + .. versionchanged:: 1.7.0 The default value has been set back to 10. Set the maximum of TCP client threads, handling TCP connections. Before 1.4.0 a TCP thread could only handle a single incoming TCP connection at a time, while after 1.4.0 it can handle a larger number of them simultaneously. Note that before 1.6.0 the TCP worker threads were created at runtime, adding a new thread when the existing ones seemed to struggle with the load, until the maximum number of threads had been reached. Starting with 1.6.0 the configured number of worker threads are immediately created at startup. - In 1.6.0 the default value was at least 10 TCP workers, but could be more if there is more than 10 TCP listeners (added via :func:`addDNSCryptBind`, :func:`addLocal`, or :func:`addTLSLocal`). In that last case there would have been as many TCP workers as TCP listeners. This led to issues in setups with a large number of TCP listeners and was therefore reverted back to 10 in 1.6.1. + In 1.6.0 the default value was at least 10 TCP workers, but could be more if there is more than 10 TCP listeners (added via :func:`addDNSCryptBind`, :func:`addLocal`, or :func:`addTLSLocal`). In that last case there would have been as many TCP workers as TCP listeners. This led to issues in setups with a large number of TCP listeners and was therefore reverted back to 10 in 1.7.0. :param int num: The number of TCP worker threads. diff --git a/pdns/dnsdistdist/docs/upgrade_guide.rst b/pdns/dnsdistdist/docs/upgrade_guide.rst index 487a7e9876..a770666287 100644 --- a/pdns/dnsdistdist/docs/upgrade_guide.rst +++ b/pdns/dnsdistdist/docs/upgrade_guide.rst @@ -8,9 +8,6 @@ Truncated responses received over UDP for DoH clients will now be retried over T :func:`setTCPUseSinglePipe` has been removed. -1.6.0 to 1.6.1 --------------- - Unless set via :func:`setMaxTCPClientThreads` the number of TCP workers now defaults to 10, instead of the number of TCP binds. 1.5.x to 1.6.0