From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Fri, 1 Oct 2021 15:03:24 +0000 (+0200)
Subject: pdnsutil check-zone: warn about @ in SOA RNAME
X-Git-Tag: auth-4.6.0-alpha1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10780%2Fhead;p=thirdparty%2Fpdns.git

pdnsutil check-zone: warn about @ in SOA RNAME

Co-authored-by: Kees Monshouwer <mind04@monshouwer.org>
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index a4ed9a8195..ea8e305536 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -370,6 +370,13 @@ static int checkZone(DNSSECKeeper &dk, UeberBackend &B, const DNSName& zone, con
         cout<<"[Warning] SOA autocomplete is deprecated, missing field(s) in SOA content: "<<rr.qname<<" IN " <<rr.qtype.toString()<< " '" << rr.content<<"'"<<endl;
       }
 
+      if(parts.size() >= 2) {
+        if(parts[1].find('@') != string::npos) {
+          cout<<"[Warning] Found @-sign in SOA RNAME, should probably be a dot (.): "<<rr.qname<<" IN " <<rr.qtype.toString()<< " '" << rr.content<<"'"<<endl;
+          numwarnings++;
+        }
+      }
+
       ostringstream o;
       o<<rr.content;
       for(int pleft=parts.size(); pleft < 7; ++pleft) {