From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 7 Oct 2021 12:34:02 +0000 (+0200)
Subject: Rename the 'queued' metric of the Remote Logger to 'processed'
X-Git-Tag: dnsdist-1.7.0-alpha2~16^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10821%2Fhead;p=thirdparty%2Fpdns.git

Rename the 'queued' metric of the Remote Logger to 'processed'

Since it was not clear at all whether 'queued' meant 'has been put
in the queue at some point, might have been sent or not' or 'actually
still in the queue' (it was the former).
---

diff --git a/pdns/remote_logger.cc b/pdns/remote_logger.cc
index 736091118f..6e41db647f 100644
--- a/pdns/remote_logger.cc
+++ b/pdns/remote_logger.cc
@@ -170,7 +170,7 @@ void RemoteLogger::queueData(const std::string& data)
   }
 
   runtime->d_writer.write(data);
-  ++d_queued;
+  ++d_processed;
 }
 
 void RemoteLogger::maintenanceThread() 
diff --git a/pdns/remote_logger.hh b/pdns/remote_logger.hh
index c00e882f22..04db3b53ad 100644
--- a/pdns/remote_logger.hh
+++ b/pdns/remote_logger.hh
@@ -90,7 +90,7 @@ public:
   void queueData(const std::string& data) override;
   std::string toString() const override
   {
-    return d_remote.toStringWithPort() + " (" + std::to_string(d_queued) + " queued, " + std::to_string(d_drops) + " dropped)";
+    return d_remote.toStringWithPort() + " (" + std::to_string(d_processed) + " processed, " + std::to_string(d_drops) + " dropped)";
   }
   void stop()
   {
@@ -109,7 +109,7 @@ private:
 
   ComboAddress d_remote;
   std::atomic<uint64_t> d_drops{0};
-  std::atomic<uint64_t> d_queued{0};
+  std::atomic<uint64_t> d_processed{0};
   uint16_t d_timeout;
   uint8_t d_reconnectWaitTime;
   std::atomic<bool> d_exiting{false};