From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 26 Oct 2021 07:16:52 +0000 (+0200)
Subject: NetmaskTree: Drop the 'noexcept' qualifier on the TreeNode ctor
X-Git-Tag: rec-4.6.0-beta1~30^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F10900%2Fhead;p=thirdparty%2Fpdns.git

NetmaskTree: Drop the 'noexcept' qualifier on the TreeNode ctor

Coverity reports that it was already too restrictive with the existing
Netmask key (see CID 1465032) and clearly is now for the AddressAndPort
one (CID 373668).
---

diff --git a/pdns/iputils.hh b/pdns/iputils.hh
index c46c5a8655..b36f0e2772 100644
--- a/pdns/iputils.hh
+++ b/pdns/iputils.hh
@@ -705,7 +705,7 @@ private:
     explicit TreeNode() noexcept :
       parent(nullptr), node(), assigned(false), d_bits(0) {
     }
-    explicit TreeNode(const key_type& key) noexcept :
+    explicit TreeNode(const key_type& key) :
       parent(nullptr), node({key.getNormalized(), value_type()}),
       assigned(false), d_bits(key.getFullBits()) {
     }