From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 25 Feb 2022 13:16:47 +0000 (+0100)
Subject: string::find(char) returns a size_type, not a bool; coverity CID 1475294
X-Git-Tag: rec-4.7.0-beta1~73^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F11365%2Fhead;p=thirdparty%2Fpdns.git

string::find(char) returns a size_type, not a bool; coverity CID 1475294
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index a1daf9d56a..87704cb417 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -3253,7 +3253,7 @@ static void allowAdditionalEntry(std::unordered_set<DNSName>& allowedAdditionals
     if (auto naptrContent = getRR<NAPTRRecordContent>(rec)) {
       auto flags = naptrContent->getFlags();
       toLowerInPlace(flags);
-      if (flags.find('a') || flags.find('s')) {
+      if (flags.find('a') != string::npos || flags.find('s') != string::npos) {
         allowedAdditionals.insert(naptrContent->getReplacement());
       }
     }