From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 8 Apr 2022 12:21:15 +0000 (+0200)
Subject: dnsdist: Document how we ignore invalid harvested addresses, as suggested by Otto... 
X-Git-Tag: auth-4.8.0-alpha0~146^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F11512%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Document how we ignore invalid harvested addresses, as suggested by Otto (thanks!)
---

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 542b9cc2a3..5a4a2ddaa8 100644
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -1063,6 +1063,8 @@ static bool isUDPQueryAcceptable(ClientState& cs, LocalHolders& holders, const s
        the address is set to 0.0.0.0:0 which makes our sendfromto() use
        the wrong address. In that case it's better to let the kernel
        do the work by itself and use sendto() instead.
+       This is indicated by setting the family to 0 which is acted upon
+       in sendUDPResponse() and DelayedPacket::().
     */
     const ComboAddress bogusV4("0.0.0.0:0");
     const ComboAddress bogusV6("[::]:0");