From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 10 Jun 2022 13:39:36 +0000 (+0200)
Subject: Run tasks from houskeeping thread in a proper way.
X-Git-Tag: auth-4.8.0-alpha0~64^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F11692%2Fhead;p=thirdparty%2Fpdns.git

Run tasks from houskeeping thread in a proper way.

Previously, this was only done if log-common-errors was true, due
to argument reversal.  In general task *would* be executed, as they
are also run after each query processed by SyncRes (so not after
packet cache hits).

Thanks to @jelu!
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 301aa9b6be..07d9e94dd6 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -2085,7 +2085,7 @@ static void houseKeeping(void*)
     // Likley a few handler tasks could be moved to the taskThread
     if (info.isTaskThread()) {
       // TaskQueue is run always
-      runTasks(g_logCommonErrors, 10);
+      runTasks(10, g_logCommonErrors);
 
       static PeriodicTask ztcTask{"ZTC", 60};
       static map<DNSName, RecZoneToCache::State> ztcStates;