From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 21 Sep 2022 12:51:29 +0000 (+0200)
Subject: dnsdist: Fix 'moving a temporary object prevents copy elision' warning
X-Git-Tag: rec-4.9.0-alpha0~25^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F11987%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix 'moving a temporary object prevents copy elision' warning
---

diff --git a/pdns/dnsdist-web.cc b/pdns/dnsdist-web.cc
index d9358cec4d..4795542c8e 100644
--- a/pdns/dnsdist-web.cc
+++ b/pdns/dnsdist-web.cc
@@ -1006,7 +1006,7 @@ static void addServerToJSON(Json::array& servers, int id, const std::shared_ptr<
     {"reuseds", (double)a->reuseds},
     {"weight", (double)a->d_config.d_weight},
     {"order", (double)a->d_config.order},
-    {"pools", pools},
+    {"pools", std::move(pools)},
     {"latency", (double)(a->latencyUsec/1000.0)},
     {"queries", (double)a->queries},
     {"responses", (double)a->responses},
@@ -1224,7 +1224,7 @@ static void handleStats(const YaHTTP::Request& req, YaHTTP::Response& resp)
   Json::object stats;
   addStatsToJSONObject(stats);
 
-  Json responseObject(std::move(Json::object({
+  Json responseObject(Json::object({
     { "daemon_type", "dnsdist" },
     { "version", VERSION },
     { "servers", std::move(servers) },
@@ -1238,7 +1238,7 @@ static void handleStats(const YaHTTP::Request& req, YaHTTP::Response& resp)
     { "local", std::move(localaddressesStr) },
     { "dohFrontends", std::move(dohs) },
     { "statistics", std::move(stats) }
-        })));
+        }));
 
   resp.headers["Content-Type"] = "application/json";
   resp.body = responseObject.dump();