From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 18 Feb 2022 15:24:11 +0000 (+0100)
Subject: QType ADDR is supposed to be used internally only.
X-Git-Tag: rec-4.5.12~5^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F12165%2Fhead;p=thirdparty%2Fpdns.git

QType ADDR is supposed to be used internally only.

Should fix #11337

(cherry picked from commit 7a278799ee23e582c3b722cea578699db1791bc2)
---

diff --git a/pdns/recursor_cache.cc b/pdns/recursor_cache.cc
index 598f226015..d881d20a00 100644
--- a/pdns/recursor_cache.cc
+++ b/pdns/recursor_cache.cc
@@ -261,7 +261,13 @@ time_t MemRecursorCache::fakeTTD(MemRecursorCache::OrderedTagIterator_t& entry,
         return -1;
       } else {
         if (!entry->d_submitted) {
-          pushTask(qname, qtype, entry->d_ttd);
+          if (qtype == QType::ADDR) {
+            pushTask(qname, QType::A, entry->d_ttd);
+            pushTask(qname, QType::AAAA, entry->d_ttd);
+          }
+	  else {
+            pushTask(qname, qtype, entry->d_ttd);
+          }
           entry->d_submitted = true;
         }
       }
diff --git a/pdns/recursordist/rec-taskqueue.cc b/pdns/recursordist/rec-taskqueue.cc
index 6b33aba0c2..1bbea4f96c 100644
--- a/pdns/recursordist/rec-taskqueue.cc
+++ b/pdns/recursordist/rec-taskqueue.cc
@@ -32,6 +32,14 @@ void runTaskOnce(bool logErrors)
 
 void pushTask(const DNSName& qname, uint16_t qtype, time_t deadline)
 {
+  switch (qtype) {
+    // Internal types
+  case QType::ENT:
+  case QType::ADDR:
+  case QType::ALIAS:
+  case QType::LUA:
+    return;
+  }
   t_taskQueue.push({qname, qtype, deadline, true});
 }