From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 13 Jun 2023 08:02:45 +0000 (+0200)
Subject: dnsdist: Fix a boolean nit as suggested by Otto
X-Git-Tag: rec-5.0.0-alpha1~172^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F12783%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix a boolean nit as suggested by Otto
---

diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index e2e123b792..fbe373cf71 100644
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -1349,7 +1349,7 @@ ProcessQueryResult processQueryAfterRules(DNSQuestion& dq, LocalHolders& holders
 
       /* we do not record a miss for queries received over DoH and forwarded over TCP
          yet, as we will do a second-lookup */
-      if (dq.ids.packetCache->get(dq, dq.getHeader()->id, &dq.ids.cacheKey, dq.ids.subnet, dq.ids.dnssecOK, forwardedOverUDP, allowExpired, false, true, (dq.ids.protocol != dnsdist::Protocol::DoH || forwardedOverUDP) ? true : false)) {
+      if (dq.ids.packetCache->get(dq, dq.getHeader()->id, &dq.ids.cacheKey, dq.ids.subnet, dq.ids.dnssecOK, forwardedOverUDP, allowExpired, false, true, dq.ids.protocol != dnsdist::Protocol::DoH || forwardedOverUDP)) {
 
         restoreFlags(dq.getHeader(), dq.ids.origFlags);