From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 21 Jun 2023 12:25:03 +0000 (+0200)
Subject: rec: Silence Coverity 1462719 Unchecked return value from library.
X-Git-Tag: rec-5.0.0-alpha1~159^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F12934%2Fhead;p=thirdparty%2Fpdns.git

rec: Silence Coverity 1462719 Unchecked return value from library.

Call should not fail and it's a best effort anyway in this case
---

diff --git a/pdns/recursordist/lwres.cc b/pdns/recursordist/lwres.cc
index ad9bcbb81d..f6c6fa2479 100644
--- a/pdns/recursordist/lwres.cc
+++ b/pdns/recursordist/lwres.cc
@@ -486,7 +486,7 @@ static LWResult::Result asyncresolve(const ComboAddress& ip, const DNSName& doma
       if (fstrmQEnabled || fstrmREnabled) {
         localip.sin4.sin_family = ip.sin4.sin_family;
         socklen_t slen = ip.getSocklen();
-        getsockname(queryfd, reinterpret_cast<sockaddr*>(&localip), &slen);
+        (void)getsockname(queryfd, reinterpret_cast<sockaddr*>(&localip), &slen); // NOLINT(cppcoreguidelines-pro-type-reinterpret-cast))
       }
       if (fstrmQEnabled) {
         logFstreamQuery(fstrmLoggers, queryTime, localip, ip, DnstapMessage::ProtocolType::DoUDP, context ? context->d_auth : boost::none, vpacket);