From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 31 Jul 2023 15:43:07 +0000 (+0200)
Subject: calidns: Fix the use of `ntohl` instead of `htonl` in ECS handling
X-Git-Tag: rec-5.0.0-alpha1~79^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13018%2Fhead;p=thirdparty%2Fpdns.git

calidns: Fix the use of `ntohl` instead of `htonl` in ECS handling
---

diff --git a/pdns/calidns.cc b/pdns/calidns.cc
index 9a428ac4c3..65949df057 100644
--- a/pdns/calidns.cc
+++ b/pdns/calidns.cc
@@ -123,7 +123,7 @@ static ComboAddress getRandomAddressFromRange(const Netmask& ecsRange)
   uint8_t bits = ecsRange.getBits();
   if (bits > 0) {
     uint32_t mod = 1 << (32 - bits);
-    result.sin4.sin_addr.s_addr = result.sin4.sin_addr.s_addr + ntohl(dns_random(mod));
+    result.sin4.sin_addr.s_addr = result.sin4.sin_addr.s_addr + htonl(dns_random(mod));
   }
   else {
     result.sin4.sin_addr.s_addr = dns_random_uint32();