From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 13 Jul 2023 08:42:55 +0000 (+0200)
Subject: dnsheader: Switch from bitfield to uint16_t whenever possible
X-Git-Tag: rec-5.0.0-alpha1~111^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13026%2Fhead;p=thirdparty%2Fpdns.git

dnsheader: Switch from bitfield to uint16_t whenever possible
---

diff --git a/pdns/dns.hh b/pdns/dns.hh
index bb7c842cfa..24a02e8a48 100644
--- a/pdns/dns.hh
+++ b/pdns/dns.hh
@@ -151,7 +151,7 @@ static_assert(sizeof(EDNS0Record) == 4, "EDNS0Record size must be 4");
 #endif
 
 struct dnsheader {
-        unsigned        id :16;         /* query identification number */
+        uint16_t        id;             /* query identification number */
 #if BYTE_ORDER == BIG_ENDIAN
                         /* fields in third byte */
         unsigned        qr: 1;          /* response flag */
@@ -180,10 +180,10 @@ struct dnsheader {
         unsigned        ra :1;          /* recursion available */
 #endif
                         /* remaining bytes */
-        unsigned        qdcount :16;    /* number of question entries */
-        unsigned        ancount :16;    /* number of answer entries */
-        unsigned        nscount :16;    /* number of authority entries */
-        unsigned        arcount :16;    /* number of resource entries */
+        uint16_t        qdcount;        /* number of question entries */
+        uint16_t        ancount;        /* number of answer entries */
+        uint16_t        nscount;        /* number of authority entries */
+        uint16_t        arcount;        /* number of resource entries */
 };
 
 static_assert(sizeof(dnsheader) == 12, "dnsheader size must be 12");