From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Mon, 24 Jul 2023 08:52:56 +0000 (+0200)
Subject: report which backend failed to instantiate
X-Git-Tag: rec-5.0.0-alpha1~83^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13065%2Fhead;p=thirdparty%2Fpdns.git

report which backend failed to instantiate
---

diff --git a/pdns/dnsbackend.cc b/pdns/dnsbackend.cc
index bd7645601b..aef1b99a3a 100644
--- a/pdns/dnsbackend.cc
+++ b/pdns/dnsbackend.cc
@@ -188,8 +188,11 @@ vector<DNSBackend *> BackendMakerClass::all(bool metadataOnly)
 
   ret.reserve(d_instances.size());
 
+  std::string current; // to make the exception text more useful
+
   try {
     for (const auto& instance : d_instances) {
+      current = instance.first + instance.second;
       DNSBackend *made = nullptr;
 
       if (metadataOnly) {
@@ -207,7 +210,7 @@ vector<DNSBackend *> BackendMakerClass::all(bool metadataOnly)
     }
   }
   catch(const PDNSException &ae) {
-    g_log<<Logger::Error<<"Caught an exception instantiating a backend: "<<ae.reason<<endl;
+    g_log<<Logger::Error<<"Caught an exception instantiating a backend (" << current << "): "<<ae.reason<<endl;
     g_log<<Logger::Error<<"Cleaning up"<<endl;
     for (auto i : ret) {
       delete i;
@@ -215,7 +218,7 @@ vector<DNSBackend *> BackendMakerClass::all(bool metadataOnly)
     throw;
   } catch(...) {
     // and cleanup
-    g_log<<Logger::Error<<"Caught an exception instantiating a backend, cleaning up"<<endl;
+    g_log<<Logger::Error<<"Caught an exception instantiating a backend (" << current <<"), cleaning up"<<endl;
     for (auto i : ret) {
       delete i;
     }