From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 15 Aug 2023 16:07:52 +0000 (+0200)
Subject: dnsdist: Remove a second useless check, useless static casts
X-Git-Tag: rec-5.0.0-alpha1~58^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13138%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Remove a second useless check, useless static casts
---

diff --git a/pdns/dnsdistdist/dnsdist-discovery.cc b/pdns/dnsdistdist/dnsdist-discovery.cc
index 2d3c66e722..5bb61ba450 100644
--- a/pdns/dnsdistdist/dnsdist-discovery.cc
+++ b/pdns/dnsdistdist/dnsdist-discovery.cc
@@ -275,7 +275,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable
     const struct timeval remainingTime = {.tv_sec = backend->d_config.tcpRecvTimeout, .tv_usec = 0};
     uint16_t responseSize = 0;
     auto got = readn2WithTimeout(sock.getHandle(), &responseSize, sizeof(responseSize), remainingTime);
-    if (static_cast<size_t>(got) != sizeof(responseSize)) {
+    if (got != sizeof(responseSize)) {
       if (g_verbose) {
         warnlog("Error while waiting for the ADD upgrade response size from backend %s: %d", addr.toStringWithPort(), got);
       }
@@ -285,7 +285,7 @@ bool ServiceDiscovery::getDiscoveredConfig(const UpgradeableBackend& upgradeable
     packet.resize(ntohs(responseSize));
 
     got = readn2WithTimeout(sock.getHandle(), packet.data(), packet.size(), remainingTime);
-    if (got < 0 || static_cast<size_t>(got) != packet.size()) {
+    if (got != packet.size()) {
       if (g_verbose) {
         warnlog("Error while waiting for the ADD upgrade response from backend %s: %d", addr.toStringWithPort(), got);
       }