From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 13 Sep 2023 10:07:08 +0000 (+0200)
Subject: rec: Fix Coverityy 1519054: Using invalid iterator
X-Git-Tag: dnsdist-1.9.0-alpha1~7^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13250%2Fhead;p=thirdparty%2Fpdns.git

rec: Fix Coverityy 1519054: Using invalid iterator
---

diff --git a/pdns/recursordist/settings/cxxsupport.cc b/pdns/recursordist/settings/cxxsupport.cc
index 84c3f1c455..bde1a244a3 100644
--- a/pdns/recursordist/settings/cxxsupport.cc
+++ b/pdns/recursordist/settings/cxxsupport.cc
@@ -491,7 +491,10 @@ std::string pdns::settings::rec::defaultsToYaml()
       withHelp = true;
     }
     if (withHelp) {
-      auto oldname = std::string(map.find(make_pair(section, field))->second.old_name);
+      std::string oldname;
+      if (auto iter = map.find(make_pair(section, field)); iter != map.end()) {
+        oldname = std::string(iter->second.old_name);
+      }
       res += "##### ";
       res += arg().getHelp(oldname);
       res += '\n';