From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Mon, 25 Sep 2023 08:52:10 +0000 (+0200)
Subject: Rename setting and adapt docs text, as suggested by @ragogne
X-Git-Tag: rec-5.0.0-alpha2~44^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13289%2Fhead;p=thirdparty%2Fpdns.git

Rename setting and adapt docs text, as suggested by @ragogne
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 43d125f236..fcf617d70d 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -1641,7 +1641,7 @@ static int initSyncRes(Logr::log_t log)
 
   SyncRes::s_serverdownmaxfails = ::arg().asNum("server-down-max-fails");
   SyncRes::s_serverdownthrottletime = ::arg().asNum("server-down-throttle-time");
-  SyncRes::s_unthrottle_n = ::arg().asNum("server-down-use-probability");
+  SyncRes::s_unthrottle_n = ::arg().asNum("bypass-server-throttling-probability");
   SyncRes::s_nonresolvingnsmaxfails = ::arg().asNum("non-resolving-ns-max-fails");
   SyncRes::s_nonresolvingnsthrottletime = ::arg().asNum("non-resolving-ns-throttle-time");
   SyncRes::s_serverID = ::arg()["server-id"];
diff --git a/pdns/recursordist/settings/table.py b/pdns/recursordist/settings/table.py
index ab7e1ceb8e..e833fb6564 100644
--- a/pdns/recursordist/settings/table.py
+++ b/pdns/recursordist/settings/table.py
@@ -2155,15 +2155,15 @@ Throttle a server that has failed to respond :ref:`setting-server-down-max-fails
  ''',
     },
     {
-        'name' : 'server_down_use_probability',
+        'name' : 'bypass_server_throttling_probability',
         'section' : 'recursor',
         'type' : LType.Uint64,
         'default' : '25',
         'help' : 'Determines the probability of a server marked down to be used anyway',
         'doc' : '''
 This setting determines the probability of a server marked down to be used anyway.
-A value of ``n`` means that the chance of a server marked down being used after it wins speed selection is is ``1/n``.
-If this setting is zero this mechanism is not active.
+A value of ``n`` means that the chance of a server marked down still being used after it wins speed selection is is ``1/n``.
+If this setting is zero throttled servers will never be selected to be used anyway.
         ''',
         'versionadded': '5.0.0'
     },