From: Christian Hofstaedtler <christian@hofstaedtler.name>
Date: Wed, 12 Mar 2014 19:48:51 +0000 (+0100)
Subject: JSON API: add zone ids to search-data results
X-Git-Tag: rec-3.6.0-rc1~139^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F1330%2Fhead;p=thirdparty%2Fpdns.git

JSON API: add zone ids to search-data results

Otherwise clients need another round-trip to /zones to get those ids.
---

diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index f0bc3d5dd0..0a86b704bd 100644
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -745,12 +745,16 @@ static void apiServerSearchData(HttpRequest* req, HttpResponse* resp) {
   Comment comment;
 
   BOOST_FOREACH(const DomainInfo& di, domains) {
+    string zoneId = apiZoneNameToId(di.zone);
+
     if (di.zone.find(q) != string::npos) {
       Value object;
       object.SetObject();
       object.AddMember("type", "zone", doc.GetAllocator());
-      Value jname(di.zone.c_str(), doc.GetAllocator()); // copy
-      object.AddMember("name", jname, doc.GetAllocator());
+      Value jzoneId(zoneId.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("zone_id", jzoneId, doc.GetAllocator());
+      Value jzoneName(di.zone.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("name", jzoneName, doc.GetAllocator());
       doc.PushBack(object, doc.GetAllocator());
     }
 
@@ -770,6 +774,10 @@ static void apiServerSearchData(HttpRequest* req, HttpResponse* resp) {
       Value object;
       object.SetObject();
       object.AddMember("type", "record", doc.GetAllocator());
+      Value jzoneId(zoneId.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("zone_id", jzoneId, doc.GetAllocator());
+      Value jzoneName(di.zone.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("zone_name", jzoneName, doc.GetAllocator());
       Value jname(rr.qname.c_str(), doc.GetAllocator()); // copy
       object.AddMember("name", jname, doc.GetAllocator());
       Value jcontent(rr.content.c_str(), doc.GetAllocator()); // copy
@@ -785,6 +793,10 @@ static void apiServerSearchData(HttpRequest* req, HttpResponse* resp) {
       Value object;
       object.SetObject();
       object.AddMember("type", "comment", doc.GetAllocator());
+      Value jzoneId(zoneId.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("zone_id", jzoneId, doc.GetAllocator());
+      Value jzoneName(di.zone.c_str(), doc.GetAllocator()); // copy
+      object.AddMember("zone_name", jzoneName, doc.GetAllocator());
       Value jname(comment.qname.c_str(), doc.GetAllocator()); // copy
       object.AddMember("name", jname, doc.GetAllocator());
       Value jcontent(comment.content.c_str(), doc.GetAllocator()); // copy
diff --git a/regression-tests.api/test_Zones.py b/regression-tests.api/test_Zones.py
index 14a0b06dc8..78e9ed62cf 100644
--- a/regression-tests.api/test_Zones.py
+++ b/regression-tests.api/test_Zones.py
@@ -498,7 +498,7 @@ class AuthZones(ApiTestCase):
         r = self.session.get(self.url("/servers/localhost/search-data?q=" + name))
         self.assertSuccessJson(r)
         print r.json()
-        self.assertEquals(r.json(), [{u'type': u'zone', u'name': name}])
+        self.assertEquals(r.json(), [{u'type': u'zone', u'name': name, u'zone_id': name+'.'}])
 
     def test_SearchRRSubstring(self):
         name = 'search-rr-zone.name'