From: Yorgos Thessalonikefs <yorgos@nlnetlabs.nl>
Date: Wed, 17 Sep 2025 10:19:20 +0000 (+0200)
Subject: code review: use proper roundrobin index
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F1337%2Fhead;p=thirdparty%2Funbound.git

code review: use proper roundrobin index

Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
---

diff --git a/util/data/msgencode.c b/util/data/msgencode.c
index 22c3ba9d7..019da7253 100644
--- a/util/data/msgencode.c
+++ b/util/data/msgencode.c
@@ -499,14 +499,14 @@ packed_rrset_encode(struct ub_packed_rrset_key* key, sldns_buffer* pkt,
 			if(key->rk.flags & PACKED_RRSET_UPSTREAM_0TTL) {
 				sldns_buffer_write_u32(pkt, 0);
 			} else if(adjust == 0) {
-				sldns_buffer_write_u32(pkt, data->rr_ttl[i]);
+				sldns_buffer_write_u32(pkt, data->rr_ttl[j]);
 			} else if(TTL_IS_EXPIRED(data->rr_ttl[j], adjust)) {
 				sldns_buffer_write_u32(pkt,
 					EXPIRED_REPLY_TTL_CALC(
-					    data->rr_ttl[i], data->ttl_add));
+					    data->rr_ttl[j], data->ttl_add));
 			} else {
 				sldns_buffer_write_u32(pkt,
-					data->rr_ttl[i] - adjust);
+					data->rr_ttl[j] - adjust);
 			}
 			if(c) {
 				if((r=compress_rdata(pkt, data->rr_data[j],