From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 8 Dec 2023 16:19:12 +0000 (+0100)
Subject: dnsdist: No need to multiply 1.0 in cache-miss ratio dynblocks
X-Git-Tag: dnsdist-1.9.0-alpha4~10^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F13492%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: No need to multiply 1.0 in cache-miss ratio dynblocks

As suggested by Charles-Henri, thanks!
---

diff --git a/pdns/dnsdistdist/dnsdist-dynblocks.cc b/pdns/dnsdistdist/dnsdist-dynblocks.cc
index 5e7d970c50..b7baca2be7 100644
--- a/pdns/dnsdistdist/dnsdist-dynblocks.cc
+++ b/pdns/dnsdistdist/dnsdist-dynblocks.cc
@@ -949,7 +949,7 @@ bool DynBlockRulesGroup::DynBlockCacheMissRatioRule::checkGlobalCacheHitRatio()
   if (globalMisses == 0 || globalHits == 0) {
     return false;
   }
-  double globalCacheHitRatio = (static_cast<double>(globalHits) * static_cast<double>(1.0)) / static_cast<double>(globalHits + globalMisses);
+  double globalCacheHitRatio = static_cast<double>(globalHits) / static_cast<double>(globalHits + globalMisses);
   return globalCacheHitRatio >= d_minimumGlobalCacheHitRatio;
 }