From: Andrew Lewis <nerf@judo.za.org>
Date: Sat, 28 Jan 2017 15:05:24 +0000 (+0200)
Subject: [Minor] Fix warnings
X-Git-Tag: 1.5.0~225^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F1382%2Fhead;p=thirdparty%2Frspamd.git

[Minor] Fix warnings

 - Also yield symbol when key in Redis was used
---

diff --git a/src/plugins/lua/dkim_signing.lua b/src/plugins/lua/dkim_signing.lua
index 5a6dcfdc0b..345c91fcb1 100644
--- a/src/plugins/lua/dkim_signing.lua
+++ b/src/plugins/lua/dkim_signing.lua
@@ -126,7 +126,6 @@ local function dkim_signing_cb(task)
   if settings.use_redis then
     p.key = nil
     local rk = string.format('%s.%s', p.selector, p.domain)
-    local ret, upstream
 
     local function redis_key_cb(err, data)
       if err or type(data) ~= 'string' then
@@ -134,11 +133,13 @@ local function dkim_signing_cb(task)
           rk, err)
       else
         p.rawkey = data
-        rspamd_plugins.dkim.sign(task, p)
+        if rspamd_plugins.dkim.sign(task, p) then
+          task:insert_result(settings.symbol, 1.0)
+        end
       end
     end
 
-    ret,_,upstream = rspamd_redis_make_request(task,
+    local ret = rspamd_redis_make_request(task,
       redis_params, -- connect params
       rk, -- hash key
       true, -- is write