From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 13 Jun 2024 10:01:33 +0000 (+0200)
Subject: dnsdist: Apply suggestion from Charles-Henri's review (thanks!)
X-Git-Tag: rec-5.2.0-alpha0~21^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F14302%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Apply suggestion from Charles-Henri's review (thanks!)
---

diff --git a/pdns/dnsdistdist/dnsdist-lua-ffi.cc b/pdns/dnsdistdist/dnsdist-lua-ffi.cc
index 6af7562efb..1443fa9e77 100644
--- a/pdns/dnsdistdist/dnsdist-lua-ffi.cc
+++ b/pdns/dnsdistdist/dnsdist-lua-ffi.cc
@@ -2166,7 +2166,7 @@ bool dnsdist_ffi_dnsquestion_generate_svc_response(dnsdist_ffi_dnsquestion_t* dn
   parameters.reserve(parametersListSize);
   for (size_t idx = 0; idx < parametersListSize; idx++) {
     // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic): this is a C API
-    const auto& parameter = parametersList[idx];
+    const auto* parameter = parametersList[idx];
     if (parameter == nullptr) {
       return false;
     }