From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 22 Aug 2024 12:37:14 +0000 (+0200)
Subject: Fix the Coverity workflow after the Quiche installation refactoring
X-Git-Tag: rec-5.2.0-alpha1~132^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F14579%2Fhead;p=thirdparty%2Fpdns.git

Fix the Coverity workflow after the Quiche installation refactoring
---

diff --git a/.github/workflows/misc-dailies.yml b/.github/workflows/misc-dailies.yml
index 5840075d82..48eee9caf1 100644
--- a/.github/workflows/misc-dailies.yml
+++ b/.github/workflows/misc-dailies.yml
@@ -93,6 +93,8 @@ jobs:
       - run: inv coverity-clang-configure
       - run: inv ci-autoconf
         working-directory: ./pdns/dnsdistdist/
+      - run: inv ci-install-rust ${{ env.REPO_HOME }}
+        working-directory: ./pdns/dnsdistdist/
       - run: inv ci-build-and-install-quiche ${{ env.REPO_HOME }}
         working-directory: ./pdns/dnsdistdist/
       - run: inv ci-dnsdist-configure full
diff --git a/tasks.py b/tasks.py
index 65c58d0d14..f2b00d5a0a 100644
--- a/tasks.py
+++ b/tasks.py
@@ -1049,6 +1049,9 @@ def coverity_upload(c, email, project, tarball):
 @task
 def ci_build_and_install_quiche(c, repo):
     with c.cd(f'{repo}/builder-support/helpers/'):
+        # be careful that rust needs to have been installed system-wide,
+        # as the one installed in GitHub actions' Ubuntu images in /home/runner/.cargo/bin/cargo
+        # is not in the path for the root user (and shouldn't be)
         c.run(f'sudo {repo}/builder-support/helpers/install_quiche.sh')
 
     # cannot use c.sudo() inside a cd() context, see https://github.com/pyinvoke/invoke/issues/687