From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 13 Sep 2024 07:59:10 +0000 (+0200)
Subject: dnsdist: Fix a few warnings from Coverity
X-Git-Tag: rec-5.2.0-alpha1~82^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F14667%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix a few warnings from Coverity
---

diff --git a/pdns/dnsdistdist/bpf-filter.cc b/pdns/dnsdistdist/bpf-filter.cc
index db8c358b1c..700f32467d 100644
--- a/pdns/dnsdistdist/bpf-filter.cc
+++ b/pdns/dnsdistdist/bpf-filter.cc
@@ -392,7 +392,7 @@ BPFFilter::BPFFilter(std::unordered_map<std::string, MapConfiguration>& configs,
     BPFFilter::MapConfiguration filters;
     filters.d_maxItems = 1;
     filters.d_type = BPFFilter::MapType::Filters;
-    maps->d_filters = BPFFilter::Map(filters, d_mapFormat);
+    maps->d_filters = BPFFilter::Map(std::move(filters), d_mapFormat);
 
     const struct bpf_insn main_filter[] = {
 #include "bpf-filter.main.ebpf"
diff --git a/pdns/dnsdistdist/dnsdist-web.cc b/pdns/dnsdistdist/dnsdist-web.cc
index 526b0bc853..5cdfead09c 100644
--- a/pdns/dnsdistdist/dnsdist-web.cc
+++ b/pdns/dnsdistdist/dnsdist-web.cc
@@ -1908,6 +1908,7 @@ void setMaxConcurrentConnections(size_t max)
 void WebserverThread(Socket sock)
 {
   setThreadName("dnsdist/webserv");
+  //coverity[auto_causes_copy]
   const auto local = *dnsdist::configuration::getCurrentRuntimeConfiguration().d_webServerAddress;
   infolog("Webserver launched on %s", local.toStringWithPort());
 
diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 8f196475f5..0efef3add9 100644
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -2340,6 +2340,7 @@ static void healthChecksThread()
 
     std::unique_ptr<FDMultiplexer> mplexer{nullptr};
     // this points to the actual shared_ptrs!
+    //coverity[auto_causes_copy]
     const auto servers = dnsdist::configuration::getCurrentRuntimeConfiguration().d_backends;
     for (const auto& dss : servers) {
       dss->updateStatisticsInfo();