From: Otto Moerbeek Date: Mon, 7 Oct 2024 09:31:49 +0000 (+0200) Subject: Apply suggestions from code review X-Git-Tag: rec-5.2.0-alpha1~45^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F14697%2Fhead;p=thirdparty%2Fpdns.git Apply suggestions from code review Co-authored-by: Remi Gacogne --- diff --git a/pdns/recursordist/settings/Makefile.am b/pdns/recursordist/settings/Makefile.am index 53b78b549b..8d186d14aa 100644 --- a/pdns/recursordist/settings/Makefile.am +++ b/pdns/recursordist/settings/Makefile.am @@ -23,8 +23,8 @@ BUILT_SOURCES=cxxsettings-generated.cc rust/src/lib.rs # # Use patterns to avoid having two instances of generate run simultaneously, a well-known hack for GNU make cxxsettings-generated%cc rust/src/lib%rs: table.py generate.py rust-preamble-in.rs rust-bridge-in.rs docs-old-preamble-in.rst docs-new-preamble-in.rst - @if test "$(PYTHON)" = ":"; then echo "Settings table table.py has changed, need python to regenerate generated settings files but python was not found"; exit 1; fi - @if ! $(PYTHON) --version | grep -q "Python 3"; then echo $(PYTHON) should be at least version 3; exit 1; fi + @if test "$(PYTHON)" = ":"; then echo "Settings table table.py has changed, python is needed to regenerate the related settings files but python was not found. Please install python and re-run configure"; exit 1; fi + @if ! $(PYTHON) --version | grep -q "Python 3"; then echo $(PYTHON) should be at least version 3. Please install python 3 and re-run configure; exit 1; fi $(MAKE) -C rust clean (cd ${srcdir} && $(PYTHON) generate.py)