From: Francis Dupont <fdupont@isc.org>
Date: Thu, 18 Sep 2025 17:34:43 +0000 (+0200)
Subject: [#4096] Addressed comments
X-Git-Tag: Kea-3.1.2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F149%2Fhead;p=thirdparty%2Fkea.git

[#4096] Addressed comments
---

diff --git a/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc b/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
index c3d6cdd83b..a1341d2678 100644
--- a/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
+++ b/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
@@ -4971,15 +4971,15 @@ TEST_F(Dhcpv4SrvTest, receiveServiceDisabledStat) {
     using namespace isc::stats;
     StatsMgr& mgr = StatsMgr::instance();
     ObservationPtr pkt4_rcvd = mgr.getObservation("pkt4-received");
-    ObservationPtr parse_fail = mgr.getObservation("pkt4-service-disabled");
+    ObservationPtr srv_disable = mgr.getObservation("pkt4-service-disabled");
     ObservationPtr recv_drop = mgr.getObservation("pkt4-receive-drop");
     ASSERT_TRUE(pkt4_rcvd);
-    ASSERT_TRUE(parse_fail);
+    ASSERT_TRUE(srv_disable);
     ASSERT_TRUE(recv_drop);
 
     // They also must have expected values.
     EXPECT_EQ(1, pkt4_rcvd->getInteger().first);
-    EXPECT_EQ(1, parse_fail->getInteger().first);
+    EXPECT_EQ(1, srv_disable->getInteger().first);
     EXPECT_EQ(1, recv_drop->getInteger().first);
 }
 
diff --git a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
index 6a0ed1ae7f..92322b5ae2 100644
--- a/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
+++ b/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
@@ -3642,13 +3642,13 @@ TEST_F(Dhcpv6SrvTest, receiveServiceDisableddStat) {
 
     // Check that the tested statistics is initially set to 0
     ObservationPtr pkt6_rcvd = mgr.getObservation("pkt6-received");
-    ObservationPtr parse_fail = mgr.getObservation("pkt6-service-disabled");
+    ObservationPtr srv_disable = mgr.getObservation("pkt6-service-disabled");
     ObservationPtr recv_drop = mgr.getObservation("pkt6-receive-drop");
     ASSERT_TRUE(pkt6_rcvd);
-    ASSERT_TRUE(parse_fail);
+    ASSERT_TRUE(srv_disable);
     ASSERT_TRUE(recv_drop);
     EXPECT_EQ(0, pkt6_rcvd->getInteger().first);
-    EXPECT_EQ(0, parse_fail->getInteger().first);
+    EXPECT_EQ(0, srv_disable->getInteger().first);
     EXPECT_EQ(0, recv_drop->getInteger().first);
 
     // Simulate that we have received that traffic
@@ -3661,15 +3661,15 @@ TEST_F(Dhcpv6SrvTest, receiveServiceDisableddStat) {
 
     // All expected statistics must be present.
     pkt6_rcvd = mgr.getObservation("pkt6-received");
-    parse_fail = mgr.getObservation("pkt6-service-disabled");
+    srv_disable = mgr.getObservation("pkt6-service-disabled");
     recv_drop = mgr.getObservation("pkt6-receive-drop");
     ASSERT_TRUE(pkt6_rcvd);
-    ASSERT_TRUE(parse_fail);
+    ASSERT_TRUE(srv_disable);
     ASSERT_TRUE(recv_drop);
 
     // They also must have expected values.
     EXPECT_EQ(1, pkt6_rcvd->getInteger().first);
-    EXPECT_EQ(1, parse_fail->getInteger().first);
+    EXPECT_EQ(1, srv_disable->getInteger().first);
     EXPECT_EQ(1, recv_drop->getInteger().first);
 }