From: Miod Vallat <miod.vallat@open-xchange.com>
Date: Thu, 9 Jan 2025 14:55:16 +0000 (+0100)
Subject: Make add-zone-key try to retrieve it back to confirm operation.
X-Git-Tag: dnsdist-2.0.0-alpha1~175^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15025%2Fhead;p=thirdparty%2Fpdns.git

Make add-zone-key try to retrieve it back to confirm operation.
---

diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index a808f4711e..866a442d53 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -2590,8 +2590,15 @@ static int addZoneKey(vector<string>& cmds, DNSSECKeeper& dk) //NOLINT(readabili
     cerr<<std::to_string(id)<<": Key was added, but backend does not support returning of key id"<<endl;
   } else if (id < -1) {
     cerr<<std::to_string(id)<<": Key was added, but there was a failure while returning the key id"<<endl;
+    return 1;
   } else {
-    cout<<std::to_string(id)<<endl;
+    try {
+      dk.getKeyById(zone, id);
+      cout<<std::to_string(id)<<endl;
+    } catch (std::exception& e) {
+      cerr<<std::to_string(id)<<": Key was added, but there was a failure while reading it back: " <<e.what()<<endl;
+      return 1;
+    }
   }
   return 0;
 }