From: Remi Gacogne Date: Mon, 20 Jan 2025 17:28:40 +0000 (+0100) Subject: dnsdist: Add more context to the new build settings X-Git-Tag: dnsdist-2.0.0-alpha1~129^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15065%2Fhead;p=thirdparty%2Fpdns.git dnsdist: Add more context to the new build settings So we can actually check later if they are still needed. --- diff --git a/builder-support/debian/dnsdist/debian-bookworm/rules b/builder-support/debian/dnsdist/debian-bookworm/rules index 4fcc760301..c02ed55e80 100755 --- a/builder-support/debian/dnsdist/debian-bookworm/rules +++ b/builder-support/debian/dnsdist/debian-bookworm/rules @@ -11,8 +11,8 @@ include /usr/share/dpkg/default.mk # for atomic support on powerpc (automatic on mipsel) LDFLAGS += -latomic # We need clang (LLVM) to link the Rust static library and the C++ code with LTO enabled -# build-id SHA1 prevents an issue with the debug symbols -# and the --no-as-needed -ldl an issue with the dlsym not being found +# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier") +# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a) LDFLAGS += -fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl CC=clang CXX=clang++ diff --git a/builder-support/debian/dnsdist/debian-buster/rules b/builder-support/debian/dnsdist/debian-buster/rules index ce9621d127..a19db4f1b9 100755 --- a/builder-support/debian/dnsdist/debian-buster/rules +++ b/builder-support/debian/dnsdist/debian-buster/rules @@ -11,8 +11,8 @@ include /usr/share/dpkg/default.mk # for atomic support on powerpc (automatic on mipsel) LDFLAGS += -latomic # We need clang (LLVM) to link the Rust static library and the C++ code with LTO enabled -# build-id SHA1 prevents an issue with the debug symbols -# and the --no-as-needed -ldl an issue with the dlsym not being found +# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier") +# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a) LDFLAGS += -fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl CC=clang CXX=clang++ diff --git a/builder-support/specs/dnsdist.spec b/builder-support/specs/dnsdist.spec index 476b279c88..42e156fdb3 100644 --- a/builder-support/specs/dnsdist.spec +++ b/builder-support/specs/dnsdist.spec @@ -81,8 +81,8 @@ export LDFLAGS=-L/usr/lib64/boost169 # We need to build with LLVM/clang to be able to use LTO, since we are linking against a static Rust library built with LLVM export CC=clang export CXX=clang++ -# build-id SHA1 prevents an issue with the debug symbols -# and the --no-as-needed -ldl an issue with the dlsym not being found +# build-id SHA1 prevents an issue with the debug symbols ("export: `-Wl,--build-id=sha1': not a valid identifier") +# and the --no-as-needed -ldl an issue with the dlsym not being found ("ld.lld: error: undefined symbol: dlsym eferenced by weak.rs:142 (library/std/src/sys/pal/unix/weak.rs:142) [...] in archive ./dnsdist-rust-lib/rust/libdnsdist_rust.a) export LDFLAGS="-fuse-ld=lld -Wl,--build-id=sha1 -Wl,--no-as-needed -ldl" %endif