From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 26 Feb 2025 06:47:42 +0000 (+0100)
Subject: Apply suggestions from code review
X-Git-Tag: dnsdist-2.0.0-alpha1~58^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15216%2Fhead;p=thirdparty%2Fpdns.git

Apply suggestions from code review

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 4e0ad3825d..0e3961c746 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -131,7 +131,7 @@ std::shared_ptr<Logr::Logger> g_slogudpout;
 static deferredAdd_t s_deferredUDPadds;
 static deferredAdd_t s_deferredTCPadds;
 
-/* first we have the handler thread, t_id == 0 (thread not created as a RecursorThread have t_id = NOT_INITED)
+/* first we have the handler thread, t_id == 0 (threads not created as a RecursorThread have t_id = NOT_INITED)
    then the distributor threads if any
    and finally the workers */
 std::vector<RecThreadInfo> RecThreadInfo::s_threadInfos;
diff --git a/pdns/recursordist/rec-main.hh b/pdns/recursordist/rec-main.hh
index acc929ce74..9a3c19dd54 100644
--- a/pdns/recursordist/rec-main.hh
+++ b/pdns/recursordist/rec-main.hh
@@ -588,7 +588,7 @@ private:
   std::string name;
   std::thread thread;
   int exitCode{0};
-  unsigned int d_myid{TID_NOT_INITED}; // should always equal to the thread_local tid;
+  unsigned int d_myid{TID_NOT_INITED}; // should always be equal to the thread_local tid;
 
   // handle the web server, carbon, statistics and the control channel
   bool handler{false};