From: Otto Moerbeek <otto@drijf.net>
Date: Wed, 5 Mar 2025 15:27:58 +0000 (+0100)
Subject: Kill a few warnings
X-Git-Tag: dnsdist-2.0.0-alpha1~38^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15260%2Fhead;p=thirdparty%2Fpdns.git

Kill a few warnings
---

diff --git a/pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc b/pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc
index ba1e732344..702acfb1ad 100644
--- a/pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc
+++ b/pdns/dnsdistdist/dnsdist-lua-bindings-kvs.cc
@@ -23,7 +23,7 @@
 #include "dnsdist-kvs.hh"
 #include "dnsdist-lua.hh"
 
-void setupLuaBindingsKVS(LuaContext& luaCtx, bool client)
+void setupLuaBindingsKVS([[maybe_unused]] LuaContext& luaCtx, [[maybe_unused]] bool client)
 {
 #ifdef HAVE_LMDB
   luaCtx.writeFunction("newLMDBKVStore", [client](const std::string& fname, const std::string& dbName, boost::optional<bool> noLock) {
diff --git a/pdns/dnsdistdist/dnsdist-rules-factory.hh b/pdns/dnsdistdist/dnsdist-rules-factory.hh
index 101d36820d..ff2cdcbb6e 100644
--- a/pdns/dnsdistdist/dnsdist-rules-factory.hh
+++ b/pdns/dnsdistdist/dnsdist-rules-factory.hh
@@ -546,11 +546,11 @@ private:
 class RE2Rule : public DNSRule
 {
 public:
-  RE2Rule(const std::string& re2)
+  RE2Rule(const std::string& /* re2 */)
   {
     throw std::runtime_error("RE2 support is disabled");
   }
-  bool matches(const DNSQuestion* dq) const override
+  bool matches(const DNSQuestion* /* dq */) const override
   {
     return false;
   }
diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 8a607f5fb3..536eb00ca9 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -1388,7 +1388,7 @@ void* pleaseSupplantAllowNotifyFor(std::shared_ptr<notifyset_t> allowNotifyFor)
   return nullptr;
 }
 
-void* pleaseSupplantProxyProtocolSettings(std::shared_ptr<NetmaskGroup> acl, std::shared_ptr<std::set<ComboAddress>> except)
+static void* pleaseSupplantProxyProtocolSettings(std::shared_ptr<NetmaskGroup> acl, std::shared_ptr<std::set<ComboAddress>> except)
 {
   t_proxyProtocolACL = std::move(acl);
   t_proxyProtocolExceptions = std::move(except);
diff --git a/pdns/recursordist/rec-rust-lib/cxxsupport.cc b/pdns/recursordist/rec-rust-lib/cxxsupport.cc
index 772d21edbe..f61add41a5 100644
--- a/pdns/recursordist/rec-rust-lib/cxxsupport.cc
+++ b/pdns/recursordist/rec-rust-lib/cxxsupport.cc
@@ -1454,7 +1454,7 @@ Wrapper<M>::Wrapper(const M& arg) :
 }
 
 template <typename M>
-Wrapper<M>::~Wrapper<M>() = default;
+Wrapper<M>::~Wrapper() = default;
 
 template <typename M>
 [[nodiscard]] const M& Wrapper<M>::get() const