From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 11 Mar 2025 09:59:32 +0000 (+0100)
Subject: Tidy annotations
X-Git-Tag: rec-5.0.10~1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15281%2Fhead;p=thirdparty%2Fpdns.git

Tidy annotations
---

diff --git a/pdns/recursordist/syncres.cc b/pdns/recursordist/syncres.cc
index a384f5966f..140ef7a45a 100644
--- a/pdns/recursordist/syncres.cc
+++ b/pdns/recursordist/syncres.cc
@@ -4183,6 +4183,7 @@ static void allowAdditionalEntry(std::unordered_set<DNSName>& allowedAdditionals
   }
 }
 
+// NOLINTNEXTLINE(readability-function-cognitive-complexity)
 void SyncRes::sanitizeRecords(const std::string& prefix, LWResult& lwr, const DNSName& qname, const QType qtype, const DNSName& auth, bool wasForwarded, bool rdQuery)
 {
   const bool wasForwardRecurse = wasForwarded && rdQuery;
diff --git a/pdns/recursordist/test-syncres_cc1.cc b/pdns/recursordist/test-syncres_cc1.cc
index d9415479d2..713405e8de 100644
--- a/pdns/recursordist/test-syncres_cc1.cc
+++ b/pdns/recursordist/test-syncres_cc1.cc
@@ -1483,6 +1483,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_with_a)
   const DNSName target("cname.powerdns.com.");
   const DNSName cnameTarget("cname-target.powerdns.com");
 
+  // NOLINTNEXTLINE(performance-unnecessary-value-param)
   resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional<Netmask>& /* srcmask */, boost::optional<const ResolveContext&> /* context */, LWResult* res, bool* /* chained */) {
     if (isRootServer(address)) {
       setLWResult(res, 0, false, false, true);
@@ -1531,6 +1532,7 @@ BOOST_AUTO_TEST_CASE(test_following_cname_chain_with_a)
   const DNSName cnameTarget1("cname-target1.powerdns.com");
   const DNSName cnameTarget("cname-target.powerdns.com");
 
+  // NOLINTNEXTLINE(performance-unnecessary-value-param)
   resolver->setAsyncCallback([&](const ComboAddress& address, const DNSName& domain, int /* type */, bool /* doTCP */, bool /* sendRDQuery */, int /* EDNS0Level */, struct timeval* /* now */, boost::optional<Netmask>& /* srcmask */, boost::optional<const ResolveContext&> /* context */, LWResult* res, bool* /* chained */) {
     if (isRootServer(address)) {
       setLWResult(res, 0, false, false, true);