From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 11 Apr 2025 07:44:16 +0000 (+0200)
Subject: dnsdist: Make clang-tidy happy by passing the settings by value
X-Git-Tag: dnsdist-2.0.0-alpha2~86^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15419%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Make clang-tidy happy by passing the settings by value
---

diff --git a/pdns/dnsdistdist/dnsdist-cache.cc b/pdns/dnsdistdist/dnsdist-cache.cc
index 79d8d118fe..12eb6e81ee 100644
--- a/pdns/dnsdistdist/dnsdist-cache.cc
+++ b/pdns/dnsdistdist/dnsdist-cache.cc
@@ -31,8 +31,8 @@
 #include "base64.hh"
 
 // NOLINTNEXTLINE(bugprone-easily-swappable-parameters): too cumbersome to change at this point
-DNSDistPacketCache::DNSDistPacketCache(const CacheSettings& settings) :
-  d_settings(settings)
+DNSDistPacketCache::DNSDistPacketCache(CacheSettings settings) :
+  d_settings(std::move(settings))
 {
   if (d_settings.d_maxEntries == 0) {
     throw std::runtime_error("Trying to create a 0-sized packet-cache");
diff --git a/pdns/dnsdistdist/dnsdist-cache.hh b/pdns/dnsdistdist/dnsdist-cache.hh
index c6e249508a..41b342aaad 100644
--- a/pdns/dnsdistdist/dnsdist-cache.hh
+++ b/pdns/dnsdistdist/dnsdist-cache.hh
@@ -52,7 +52,7 @@ public:
     bool d_keepStaleData{false};
   };
 
-  DNSDistPacketCache(const CacheSettings& settings);
+  DNSDistPacketCache(CacheSettings settings);
 
   void insert(uint32_t key, const boost::optional<Netmask>& subnet, uint16_t queryFlags, bool dnssecOK, const DNSName& qname, uint16_t qtype, uint16_t qclass, const PacketBuffer& response, bool receivedOverUDP, uint8_t rcode, boost::optional<uint32_t> tempFailureTTL);
   bool get(DNSQuestion& dnsQuestion, uint16_t queryId, uint32_t* keyOut, boost::optional<Netmask>& subnet, bool dnssecOK, bool receivedOverUDP, uint32_t allowExpired = 0, bool skipAging = false, bool truncatedOK = true, bool recordMiss = true);