From: Remi Gacogne Date: Thu, 10 Jul 2025 07:55:13 +0000 (+0200) Subject: dnsdist: Properly link with `libdl` when building with `autotools` X-Git-Tag: rec-5.4.0-alpha0~46^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=refs%2Fpull%2F15813%2Fhead;p=thirdparty%2Fpdns.git dnsdist: Properly link with `libdl` when building with `autotools` Depending on the system we might actually need to link with `libdl` when our Rust library is used, and the mechanism to do that was not properly set up when building with `autotools` (we were adding `LIBDL` to the the libraries we need but the variable was not properly filled). Unfortunately the systems we are exercising in our CI do not need to explicitly link with `libdl` so we did not notice. Signed-off-by: Remi Gacogne --- diff --git a/pdns/dnsdistdist/configure.ac b/pdns/dnsdistdist/configure.ac index 82d9dae2b5..fbfd93d68e 100644 --- a/pdns/dnsdistdist/configure.ac +++ b/pdns/dnsdistdist/configure.ac @@ -15,7 +15,9 @@ CPPFLAGS="-DDNSDIST $CPPFLAGS" m4_pattern_forbid([^_?PKG_[A-Z_]+$], [*** pkg.m4 missing, please install pkg-config]) LT_PREREQ([2.2.2]) -LT_INIT([disable-static]) +# Rust runtime uses dlopen from its static lib +LT_INIT([disable-static dlopen]) +AC_SUBST([LIBDL], [$lt_cv_dlopen_libs]) CFLAGS="-g -O3 -Wall -Wextra -Wshadow -fvisibility=hidden $CFLAGS" CXXFLAGS="-g -O3 -Wall -Wextra -Wshadow -Wmissing-declarations -Wredundant-decls -fvisibility=hidden $CXXFLAGS"